Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: menu should not be garbage-collected when popuping (6-1-x) #21226

Merged
merged 1 commit into from Nov 20, 2019
Merged

fix: menu should not be garbage-collected when popuping (6-1-x) #21226

merged 1 commit into from Nov 20, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Nov 20, 2019

Backport of #21169.

Notes: Fix context menu disappearing when showing.

@zcbenz zcbenz requested a review from miniak November 20, 2019 11:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2019
@trop trop bot mentioned this pull request Nov 20, 2019
Merged
6 tasks
@trop trop bot added 6-1-x backport This is a backport PR labels Nov 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2019
@jkleinsc jkleinsc merged commit 0b2c61a into 6-1-x Nov 20, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 20, 2019

Release Notes Persisted

Fix context menu disappearing when showing.

@jkleinsc jkleinsc deleted the retain-menu-popup-6-1-x branch November 20, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
6-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zcbenz @jkleinsc @miniak