Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"--ignore-connections-limit" commandLine switch stopped working in Electron@7 #21255

Closed
3 tasks done
Kilian opened this issue Nov 22, 2019 · 3 comments · Fixed by #21286
Closed
3 tasks done

"--ignore-connections-limit" commandLine switch stopped working in Electron@7 #21255

Kilian opened this issue Nov 22, 2019 · 3 comments · Fixed by #21286
Labels
7-0-x 7-1-x bug/regression ↩️ A new version of Electron broke something

Comments

@Kilian
Copy link
Member

Kilian commented Nov 22, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: 7.1.2
  • Operating System: Ubuntu 18.04 x64
  • Last Known Working Electron version: 6.x

Expected Behavior

Setting the "ignore-connections-limit" commandLine switch for localhost should allow more than 4 connections to e.g. the gatsby development server, which limits it to that number. This is the behaviour in Electron@6

Actual Behavior

The "ignore-connections-limit" seems to have no effect anymore in electron@7.

To Reproduce

  1. Run a gatsby local server, like https://github.com/gatsbyjs/gatsby-starter-hello-world
  2. Launch this fiddle with electron@6, and see that all 6 iframes load the site: https://gist.github.com/Kilian/d35badc28200c3229b1028243433cf54
  3. Launch the fiddle with electron@7, see that none of the iframes load anymore
  4. Remove two iframes, launch with electron@7, see that the iframes now do load

Note

Note that our documentation still mentions the flag as working: https://electronjs.org/docs/api/chrome-command-line-switches#--ignore-connections-limitdomains

@nornagon
Copy link
Member

I don't think ignore-connections-limit was ever a Chrome switch. Looks like it got inadvertently removed here: #19644

@deepak1556
Copy link
Member

Yeah its not a chrome switch, and yup its accidentally removed there.

@Kilian Kilian added 7-0-x 7-1-x bug/regression ↩️ A new version of Electron broke something labels Nov 23, 2019
@Kilian
Copy link
Member Author

Kilian commented Nov 23, 2019

ref: https://github.com/electron/electron/pull/19644/files#diff-8c1eed0d78f8872226e8dd910fccb551L245

Can it be re-introduced in the new classes?

@sofianguy sofianguy added this to Fixed in 8.0.0-beta.4 in 8.2.x Dec 9, 2019
@sofianguy sofianguy added this to Fixed in 7.1.3 in 7.2.x Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x 7-1-x bug/regression ↩️ A new version of Electron broke something
Projects
No open projects
7.2.x
Fixed in 7.1.3
8.2.x
Fixed in 8.0.0-beta.4
Development

Successfully merging a pull request may close this issue.

3 participants