Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrowserWindow won't go fullscreen on instantiation on Ubuntu #21259

Closed
benfrancis opened this issue Nov 22, 2019 · 6 comments
Closed

BrowserWindow won't go fullscreen on instantiation on Ubuntu #21259

benfrancis opened this issue Nov 22, 2019 · 6 comments
Labels
7-1-x bug/regression ↩️ A new version of Electron broke something platform/linux
Projects

Comments

@benfrancis
Copy link

Preflight Checklist

  • [x ] I have read the Contributing Guidelines for this project.
  • [x ] I agree to follow the Code of Conduct that this project adheres to.
  • [x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 7.1.2
  • Operating System:
    • Ubuntu 18.04.3 LTS
  • Last Known Working Electron version:
    • 6.0.6

Expected Behavior

BrowserWindow created in fullscreen mode

Actual Behavior

Can see toolbar with File, Edit, View etc. menus

To Reproduce

$ git clone https://github.com/webianproject/shell-kiosk.git
$ cd shell-kiosk
$ npm install
$ npm start

BrowserView is instantiated here https://github.com/webianproject/shell-kiosk/blob/master/chrome.js#L17

    this.mainWindow = new BrowserWindow({
      fullscreen: true,
      webPreferences: {
        nodeIntegration: true,
        webviewTag: true
      }
    });

Additional Information

Used to work on Electron 6.0.6. First noticed the problem after upgrading to Electron 7.1.2.
Still works on Mac OS.

@benfrancis benfrancis changed the title BrowserWindow won't go fullscreen on instantiation on Ubuntu BrowserWindow won't go fullscreen on instantiation on Ubuntu Nov 22, 2019
@benfrancis
Copy link
Author

Likely related to or a duplicate of #21268

@ckerr ckerr added 7-1-x bug/regression ↩️ A new version of Electron broke something platform/linux labels Dec 4, 2019
@benfrancis
Copy link
Author

Note: Bug also reproduces on Ubuntu Core.

@benfrancis
Copy link
Author

As per #21088 (comment), Menu.setApplicationMenu(null) makes the offending menu disappear and the application takes up the whole screen.

So on reflection, the issue may not be that the BrowserWindow isn't going fullscreen, but that the menu is displayed when it shouldn't be.

@sofianguy sofianguy added this to Unsorted Issues in 7.2.x Dec 9, 2019
@lkostrowski
Copy link

I have the same problem on Ubuntu 20.x, kiosk doesnt hide icons tray :<
I used hack with setting app size using display bounds for now

@electron-triage
Copy link

The Electron version reported on this issue is no longer supported. See our supported versions documentation.

If this is still reproducible on a supported version, please open a new issue with any other new information that a maintainer should know.

Thank you for taking the time to report this issue and helping to make Electron better! Your help is appreciated.

@benfrancis
Copy link
Author

I can verify that this bug no longer reproduces in Electron 9.4.3 when running under Ubuntu Desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-1-x bug/regression ↩️ A new version of Electron broke something platform/linux
Projects
No open projects
7.2.x
Unsorted Issues
Development

No branches or pull requests

4 participants