Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window menu should handle keys correctly #21453

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 10, 2019

Backport of #21434

See that PR for details.

Notes: Fix a weird behaviors and crashes when controlling window menu by keys.

@trop trop bot requested a review from a team as a code owner December 10, 2019 07:16
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 10, 2019
@trop trop bot requested a review from zcbenz December 10, 2019 07:16
@trop trop bot added 7-1-x backport This is a backport PR labels Dec 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 10, 2019
@codebytere codebytere merged commit 89a7bdb into 7-1-x Dec 10, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 10, 2019

Release Notes Persisted

Fix a weird behaviors and crashes when controlling window menu by keys.

@codebytere codebytere deleted the trop/7-1-x-bp-fix-window-menu-should-handle-keys-correctly-1575962171590 branch December 10, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-1-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants