Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sourcemaps over file:// not loading with network service #21494

Merged
merged 1 commit into from Dec 13, 2019
Merged

fix: sourcemaps over file:// not loading with network service #21494

merged 1 commit into from Dec 13, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 12, 2019

Backport of #21473

See that PR for details.

Notes: fix source maps not loading in devtools with file scheme

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 12, 2019
@trop trop bot requested a review from deepak1556 December 12, 2019 07:58
@trop trop bot mentioned this pull request Dec 12, 2019
Merged
6 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Dec 12, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 12, 2019
@codebytere
Copy link
Member 

not ok 588 Menu module Menu.setApplicationMenu does not override null menu on startup
  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\vsts-agent-win-x86-2.148.2\_work\1\s\src\electron\spec-main\api-menu-spec.ts)
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

seems unrelated but also is concerning cc @zcbenz

@zcbenz
Copy link
Member

zcbenz commented Dec 12, 2019

seems unrelated but also is concerning cc @zcbenz

#21488 should be able to fix this flaky test.

@deepak1556 deepak1556 merged commit 96e7b44 into 7-1-x Dec 13, 2019
@release-clerk
Copy link

release-clerk bot commented Dec 13, 2019

Release Notes Persisted

fix source maps not loading in devtools with file scheme

@deepak1556
Copy link
Member

Failures are unrelated, merging.

@deepak1556 deepak1556 deleted the trop/7-1-x-bp-fix-sourcemaps-over-file-not-loading-with-network-service-1576137511066 branch December 13, 2019 01:30
@bendemboski bendemboski mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @deepak1556