Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 7: wrong type for preloadURL vs preload #21553

Closed
bpasero opened this issue Dec 17, 2019 · 1 comment
Closed

Electron 7: wrong type for preloadURL vs preload #21553

bpasero opened this issue Dec 17, 2019 · 1 comment

Comments

@bpasero
Copy link
Contributor

bpasero commented Dec 17, 2019

The documentation of preload reads: This option will appear as preloadURL (not preload) in the webPreferences specified to the will-attach-webview event.

However the type is not present anywhere in electron.d.ts

//cc @MarshallOfSound

@nornagon
Copy link
Member

This is a bit awkward because even though it's technically allowable to specify a file:// URL to WebPreferences anywhere via preloadURL, it's a bit useless to do so, since preload is right there and loads a path. #33228 to solve this a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants