Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 7.1.7: accessibilityLabel does not appear for touch bar button #21715

Closed
bpasero opened this issue Jan 9, 2020 · 2 comments
Closed

Comments

@bpasero
Copy link
Contributor

bpasero commented Jan 9, 2020

Issue Details

  • Electron Version:
    • 7.1.7
  • Operating System:
    • macOS

Expected Behavior

With #20454 there should be a new accessibilityLabel property on touchbar items.

Actual Behavior

There is no such property in electron.d.ts

To Reproduce

Simply depend on "electron": "7.1.7" in package.json and check the types.

//cc @MarshallOfSound @deepak1556

@jacobq
Copy link
Contributor

jacobq commented Jan 9, 2020

I don't think that PR has landed in 7.x (you could request that it be backported, but as it appears to be an experimental API I don't think that would be a good idea -- see also versioning policy), but I see it in v8.0.0-beta.1.

@MarshallOfSound
Copy link
Member

Yeah that property was not sent back to 7.x, it's semver/minor and therefore only expected in 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants