Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification crash in destructor on app quit #21719

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 9, 2020

Backport of #21709

See that PR for details.

Notes: Fixed a crash that would occur when Notifications were closed in concert with app termination.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 9, 2020
@trop trop bot requested a review from codebytere January 9, 2020 17:43
@trop trop bot added 7-1-x backport This is a backport PR labels Jan 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 9, 2020
@codebytere codebytere merged commit c56e5ab into 7-1-x Jan 10, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 10, 2020

Release Notes Persisted

Fixed a crash that would occur when Notifications were closed in concert with app termination.

@codebytere codebytere deleted the trop/7-1-x-bp-fix-notification-crash-in-destructor-on-app-quit-1578591773276 branch January 10, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-1-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant