fix: don't unnecessarily copy draggable regions #21723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
In some calls to `BrowserWindow::UpdateDraggableRegions` the parameter `regions` points to object's variable `draggable_regions_` which we later try to update with data received in the parameter. In these cases coping is unnecessary. Additionally after this code is executed `draggable_regions_` would be empty and as a result whole window would be undraggable.
6 tasks
nornagon
approved these changes
Jan 9, 2020
zcbenz
approved these changes
Jan 13, 2020
|
Release Notes Persisted
|
zcbenz
deleted the
trop/7-1-x-bp-fix-don-t-unnecessarily-copy-draggable-regions-1578600829874
branch
|
@zcbenz @Trop @nornagon this issue, or one a lot like it, persists |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21704
See that PR for details.
notes: Fixed an issue that could cause frameless windows to become undraggable in some circumstances.