Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fallback to OpenFolderViaShell #21749

Merged
merged 1 commit into from Jan 13, 2020
Merged

fix: don't fallback to OpenFolderViaShell #21749

merged 1 commit into from Jan 13, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 13, 2020

Backport of #21668

See that PR for details.

Notes: Fixed an issue with potential duplicate error popups when calling shell.showItemInFolder on Windows

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2020
@trop trop bot requested a review from codebytere January 13, 2020 00:50
@trop trop bot mentioned this pull request Jan 13, 2020
Merged
4 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Jan 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2020
@zcbenz zcbenz merged commit ae27218 into 7-1-x Jan 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 13, 2020

Release Notes Persisted

Fixed an issue with potential duplicate error popups when calling shell.showItemInFolder on Windows

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-don-t-fallback-to-openfolderviashell-1578876604258 branch January 13, 2020 05:56
@MRayermannMSFT MRayermannMSFT mentioned this pull request Jun 1, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere