Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when loading a http only site as https with a webview #21825

Closed
3 tasks done
Jelmerro opened this issue Jan 18, 2020 · 1 comment
Closed
3 tasks done

Crash when loading a http only site as https with a webview #21825

Jelmerro opened this issue Jan 18, 2020 · 1 comment

Comments

@Jelmerro
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 8.0.0-beta.7, 8.0.0-beta.5 and probably most other electron 8 versions
  • Operating System:
    • Fedora 30, Fedora 31 and Ubuntu 18.04
  • Last Known Working Electron version:
    • Most if not any version of electron 7, including 7.1.9

Expected Behavior

  • Find a website that only supports http
  • Set the src attribute of a webview to the https:// version of that website
  • Expect electron to throw a ERR_CERT_COMMON_NAME_INVALID error or similar

Actual Behavior

  • Find a website that only supports http
  • Set the src attribute of a webview to the https:// version of that website
  • Electron crashes with exit code 0 and without any logging or errors

To Reproduce

  • Set the src attribute of a webview to a https url that will redirect to http
  • Example fiddle

This behaviour is also present when trying to set the src attribute at any later stage,
even when doing so from inside the developer tools.

@Jelmerro
Copy link
Author

This seems to be fixed in 8.0.1 and beta versions of 9.
PR: #22124

@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 8.2.x Feb 26, 2020
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 8.0.1 in 8.2.x Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
8.2.x
Fixed in 8.0.1
Development

No branches or pull requests

2 participants