Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in AllowCertificateError #22030

Closed
3 tasks done
csetera opened this issue Feb 4, 2020 · 2 comments
Closed
3 tasks done

Crash in AllowCertificateError #22030

csetera opened this issue Feb 4, 2020 · 2 comments

Comments

@csetera
Copy link

csetera commented Feb 4, 2020

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • v8.0.0
  • Operating System:
    • macOS 10.15.3
    • Ubuntu Linux 18.04
  • Last Known Working Electron version:
    • 5.x

Expected Behavior

Should not crash

Actual Behavior

Crashed when navigating. This happens in my app when a BrowserView is opened to iheartradio.com

To Reproduce

I don't have a simple public example at this time. Can try to put something together.

Following information was captured by Crash Reporter to Backtrace.

CrashReporterInfo.zip

@csetera
Copy link
Author

csetera commented Feb 5, 2020

A bit more information. If I create the following:

        app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
            this.logger.debug('Certificate Error for URL: %s error: %s', url, error);
            if (error === 'net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM') {
                event.preventDefault()
                callback(true)
            } else {
                callback(false);
            }
          });

I will see that the error is:
Certificate Error for URL: wss://quickio.iheart.com/ error: net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM

I can cause the crash with a registered handler without any handling logic:

        app.on('certificate-error', (event, webContents, url, error, certificate, callback) => {
            this.logger.debug('Certificate Error for URL: %s error: %s', url, error);
            // if (error === 'net::ERR_CERT_WEAK_SIGNATURE_ALGORITHM') {
            //     event.preventDefault()
            //     callback(true)
            // } else {
            //     callback(false);
            // }
          });

The same error will be logged, however the app will crash. It appears that this crash is caused by unhandled certificate errors.

@csetera
Copy link
Author

csetera commented Feb 15, 2020

This is resolved by #22124

@csetera csetera closed this as completed Feb 15, 2020
@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 8.2.x Feb 19, 2020
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 8.0.2 in 8.2.x Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
8.2.x
Fixed in 8.0.2
Development

No branches or pull requests

2 participants