Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor #22114

Merged
merged 1 commit into from Feb 10, 2020
Merged

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor #22114

merged 1 commit into from Feb 10, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 9, 2020

Backport of #22056

See that PR for details.

Notes: Fixed issue where renderers could crash during GC when using the contextBridge module

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2020
@trop trop bot requested a review from MarshallOfSound February 9, 2020 04:50
@trop trop bot mentioned this pull request Feb 9, 2020
Merged
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2020
@zcbenz zcbenz merged commit 72bccd1 into 8-x-y Feb 10, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 10, 2020

Release Notes Persisted

Fixed issue where renderers could crash during GC when using the contextBridge module

@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-use-a-weakptr-so-we-do-not-uaf-the-store-in-functionlifetimemonitor-1581223796665 branch February 10, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @MarshallOfSound