Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash on invalid certs #22124

Merged
merged 3 commits into from Feb 11, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 10, 2020

Backport of #21976.

(Also backports #21978)

Notes: Fixed a crash that could occur when visiting HTTPS sites with invalid certificates.

@trop trop bot added 8-x-y backport This is a backport PR labels Feb 10, 2020
@trop trop bot mentioned this pull request Feb 10, 2020
5 tasks
@nornagon nornagon changed the title test: add test for app.on('certificate-error') event (#21978) fix: don't crash on invalid certs Feb 10, 2020
@codebytere codebytere merged commit 637cf8a into 8-x-y Feb 11, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 11, 2020

Release Notes Persisted

Fixed a crash that could occur when visiting HTTPS sites with invalid certificates.

@codebytere codebytere deleted the backport/8-x-y/certificate-error-test branch February 11, 2020 23:46
@csetera csetera mentioned this pull request Feb 15, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants