Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'webRequest' or 'webRequestBlocking' extension permissions prevents loading #22175

Closed
3 tasks done
samuelmaddock opened this issue Feb 12, 2020 · 1 comment
Closed
3 tasks done

Comments

@samuelmaddock
Copy link
Member

samuelmaddock commented Feb 12, 2020

relates to #19447

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • v9.0.0-beta.1
  • Operating System:
    • Windows 10.0.18362 Build 18362 64-bit
  • Last Known Working Electron version:
    • N/A

Expected Behavior

When an extension is loaded using Session.loadExtension with webRequest or webRequestBlocking permissions, no effect should be taken since these are currently unsupported Chrome APIs.

Actual Behavior

Loading an extension with webRequest or webRequestBlocking permissions causes all app network events to hang without resolving.

Adding a delay to calling Window.loadURL can fix the issue (seems like a race condition).

To Reproduce

This is likely the fastest way to test this issue:

  1. Modify spec-main/fixtures/extensions/content-script/manifest.json to include the following:
"permissions": ["webRequest", "webRequestBlocking", "<all_urls>"]
  1. Re-run spec-main/extensions-spec.ts tests and it should prevent loading any content in the window.

Otherwise you can try this repo:
https://github.com/samuelmaddock/electron-extensions-loading-blocked-bug

Screenshots

App not loading after calling win.loadURL('https://www.electronjs.org/')
electron_2020-02-12_18-16-08aZeL

@sofianguy sofianguy added this to Unsorted Issues in 9-x-y Feb 14, 2020
@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 9-x-y Feb 19, 2020
@sofianguy sofianguy moved this from Blocks Stable to Does Not Block Stable in 9-x-y May 6, 2020
@samuelmaddock
Copy link
Member Author

samuelmaddock commented Jan 30, 2021

Closing as this seems to be fixed now by #22655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
9-x-y
Does Not Block Stable
Development

No branches or pull requests

2 participants