Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showItemInFolder doesn't work on Windows if . is in the path #23884

Open
3 tasks done
MRayermannMSFT opened this issue Jun 1, 2020 · 20 comments
Open
3 tasks done

showItemInFolder doesn't work on Windows if . is in the path #23884

MRayermannMSFT opened this issue Jun 1, 2020 · 20 comments

Comments

@MRayermannMSFT
Copy link
Contributor

MRayermannMSFT commented Jun 1, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 8.3.0
    • 7.1.9
  • Operating System:
    • Windows
  • Last Known Working Electron version:
    • 7.1.8

Expected Behavior

Use shell.showItemInFolder to show the contents of a folder:

shell.showItemInFolder("C:\\repos\\.");

Actual Behavior

The contents of the folder is show in file explorer.

To Reproduce

// show contents of some folder on your machine
shell.showItemInFolder("C:\\repos\\.");

Additional Information

  • I have a feeling that this is what broke this.
  • Using shell.openItem still results in the expected behavior, even if there is a . in the path
  • That said, this does not repro on macOS and Linux. So while I'd be fine with this not getting fixed and just being told "use openItem" because of the 2nd bullet, it'd be nice if the APIs were consistent across platforms. 🙃
@electron-triage
Copy link

The Electron version reported on this issue is no longer supported. See our supported versions documentation.

If this is still reproducible on a supported version, please open a new issue with any other new information that a maintainer should know.

Thank you for taking the time to report this issue and helping to make Electron better! Your help is appreciated.

@MRayermannMSFT
Copy link
Contributor Author

For the record, this still reproduces in 11.x.y. I've already taken the time to workaround to using shell.openPath if the path ends with . though, so I don't feel the need to open a new issue.

@nornagon nornagon reopened this Mar 15, 2021
@nornagon
Copy link
Member

Given the version range, this is almost certainly caused by ae27218.

cc @codebytere

@uniqueUsername496
Copy link

I just encountered this issue at 12.0.4 and my path has a dot in the middle of it (eg C:/Folder.Name/file). But path.normalize is a workaround. (also gets rid of the backslash issue on windows: #11617)
Thanks @KavenWork for pointing it out there

@ArnieGA
Copy link

ArnieGA commented Jun 14, 2022

I just encountered this issue at 12.0.4 and my path has a dot in the middle of it (eg C:/Folder.Name/file). But path.normalize is a workaround. (also gets rid of the backslash issue on windows: #11617) Thanks @KavenWork for pointing it out there

Thank you very very much; indeed path.normalize did the trick for me. Cheers! :-)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 8, 2022
@ArnieGA
Copy link

ArnieGA commented Oct 8, 2022 via email

@github-actions github-actions bot removed the stale label Oct 9, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 10, 2023
@MRayermannMSFT
Copy link
Contributor Author

bump

@github-actions github-actions bot removed the stale label Jan 11, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Apr 12, 2023
@MRayermannMSFT
Copy link
Contributor Author

bump

@github-actions github-actions bot removed the stale label Apr 13, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jul 12, 2023
@MRayermannMSFT
Copy link
Contributor Author

bump

@github-actions github-actions bot removed the stale label Jul 13, 2023
@ArnieGA
Copy link

ArnieGA commented Jul 19, 2023

bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@MRayermannMSFT
Copy link
Contributor Author

bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@MRayermannMSFT
Copy link
Contributor Author

Bump

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@MRayermannMSFT
Copy link
Contributor Author

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants