fix: don't run environment bootstrapper #23924

ckerr · 2020-06-02T23:47:18Z

Manually backport #22342 to 8-x-y. See that PR for details.

CC @codebytere in particular and @electron/wg-releases in general

PR description included and stakeholders cc'd
npm test passes
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed an issue where some logging would double-print.

release-clerk · 2020-06-03T15:12:33Z

Release Notes Persisted

Fixed an issue where some logging would double-print.

ckerr and others added 4 commits June 2, 2020 16:39

chore: remove node "split CreateEnvironment" patch

80c3671

chore: remove environment.js from electron-node

8db0d58

chore: do not call the electron-node API we just removed

ac8245d

fix: don't prepareMainExecution twice

28e23e8

ckerr requested a review from codebytere June 2, 2020 23:47

ckerr requested a review from a team as a code owner June 2, 2020 23:47

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020

trop bot mentioned this pull request Jun 2, 2020

fix: don't run environment bootstrapper #22342

Merged

4 tasks

trop bot added 8-x-y backport This is a backport PR labels Jun 2, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2020

codebytere approved these changes Jun 3, 2020

View reviewed changes

ckerr merged commit c374f20 into 8-x-y Jun 3, 2020

ckerr deleted the backport/8-x-y/22342-dont-run-environment-bootstrapper branch June 3, 2020 15:12

Provide feedback