Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add worldSafe flag for executeJS results #24712

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 23, 2020

Backport of #24114

See that PR for details.

Notes: Added new worldSafeExecuteJavaScript webPreference to ensure that the return values from webFrame.executeJavaScript are world safe when context isolation is enabled

@trop trop bot requested a review from MarshallOfSound July 23, 2020 21:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 23, 2020
@trop trop bot added 9-x-y backport This is a backport PR backport/requested 🗳 labels Jul 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2020
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Release WG

@jkleinsc jkleinsc merged commit a579582 into 9-x-y Aug 5, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 5, 2020

Release Notes Persisted

Added new worldSafeExecuteJavaScript webPreference to ensure that the return values from webFrame.executeJavaScript are world safe when context isolation is enabled

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-feat-add-worldsafe-flag-for-executejs-results-1595539959911 branch August 5, 2020 16:08
Copy link

@kaymarie26 kaymarie26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acrosman added a commit to acrosman/electronForce that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants