Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: save crash reports locally when uploadToServer: false on linux #24788

Merged
merged 1 commit into from Jul 31, 2020
Merged

fix: save crash reports locally when uploadToServer: false on linux #24788

merged 1 commit into from Jul 31, 2020

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Jul 30, 2020 •
edited

Description of Change

Backports #24778

Checklist

Release Notes

Notes: save crash reports locally when uploadToServer: false on linux

@deepak1556 @nornagon
fix: save crash reports locally when uploadToServer: false on linux (#…
552b55b 
…24778)

* fix: generate dumps under crashDumps folder in linux

* Update spec-main/api-crash-reporter-spec.ts

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2020
@trop trop bot mentioned this pull request Jul 30, 2020
Merged
7 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jul 30, 2020
@deepak1556 deepak1556 requested a review from a team July 30, 2020 02:41
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2020
@deepak1556 deepak1556 merged commit 0107cab into 9-x-y Jul 31, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2020

Release Notes Persisted

save crash reports locally when uploadToServer: false on linux

@deepak1556 deepak1556 deleted the robo/fix_crash_dump_linux_9_x branch July 31, 2020 06:20
@implausible implausible mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere