Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer tools console autocomplete broken in Electron 11+ #26980

Closed
3 tasks done
lishid opened this issue Dec 14, 2020 · 4 comments
Closed
3 tasks done

Developer tools console autocomplete broken in Electron 11+ #26980

lishid opened this issue Dec 14, 2020 · 4 comments
Assignees
@MarshallOfSound
Labels
11-x-y bug/regression ↩️ A new version of Electron broke something platform/all

Comments

@lishid
Copy link
Contributor

lishid commented Dec 14, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.0-11.1.0
  • Operating System:
    • Windows 10 1909
  • Last Known Working Electron version:
    • 10.2.0
  • Auto-suggestion box keeps suggesting window after typing .
  • No suggestions for anything after .
  • If you press ESC, then you will never have auto suggestion again, unless you clear and start over.
  • Auto-type (grey'd out ghost characters you can press tab to choose) no longer available after .

Expected Behavior (Recorded in v10.2.0)

test

Actual Behavior (Recorded in v11.0.0)

test

Additional Information

Developer tools console works fine in Chrome 87.0.4280.88
@lishid lishid changed the title Developer tools console autocomplete broken Developer tools console autocomplete broken in Electron 11+ Dec 14, 2020
@MarshallOfSound MarshallOfSound self-assigned this Dec 14, 2020
@ckerr ckerr added 11-x-y bug/regression ↩️ A new version of Electron broke something platform/windows labels Dec 16, 2020
@ckerr ckerr added this to Unsorted Issues in 12-x-y Dec 16, 2020
@sofianguy sofianguy moved this from Unsorted Issues to Does Not Block Stable in 12-x-y Dec 17, 2020
@ilyagelman
Copy link

ilyagelman commented Dec 17, 2020 •
edited

Same regression on macOS (Big Sur on Intel processor)

@nornagon
Copy link
Member

nornagon commented Dec 17, 2020 •
edited

Bisected to v11.0.0-nightly.20200721...v11.0.0-nightly.20200723. Likely culprit is 2fb14f5.

@lishid
Copy link
Contributor Author

lishid commented Dec 20, 2020

Upon further investigation, it seems that the debugger is also broken. I believe it's related but it's also possible it's unrelated. Let me know if I should file a separate issue for this.

Scope variables don't show up.

Expected (Chrome):
image

Broken (Electron v11):
image

Additionally, these are also broken in Electron v11, severely limiting the debugging experience

Hover over variables in Chrome:
image

Execute line by line and see inline variable contents in Chrome:
image

@MarshallOfSound MarshallOfSound mentioned this issue Dec 21, 2020
Merged
@MarshallOfSound
Copy link
Member

Fixed in #27102

@codebytere codebytere removed this from Does Not Block Stable in 12-x-y Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
11-x-y bug/regression ↩️ A new version of Electron broke something platform/all
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ckerr @ilyagelman @nornagon @lishid @MarshallOfSound