Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: registerStringProtocol crashes the entry app #28579

Closed
mahnunchik opened this issue Apr 8, 2021 · 5 comments
Closed

[Bug]: registerStringProtocol crashes the entry app #28579

mahnunchik opened this issue Apr 8, 2021 · 5 comments

Comments

@mahnunchik
Copy link
Contributor

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

9.4.4, 10.4.2, 11.4.2, 12.0.2

What operating system are you using?

macOS

Operating System Version

11.2.2

What arch are you using?

x64

Last Known Working Electron version

Expected Behavior

App works

Actual Behavior

App crashes

Testcase Gist URL

https://gist.github.com/mahnunchik/aaef0dffd6c03020b80c58925f31d2af

But removing callback call from the registerStringProtocol handler keeps app working.

@mahnunchik
Copy link
Contributor Author

mahnunchik commented Apr 8, 2021

@mahnunchik
Copy link
Contributor Author

@pfrazee previous fix is from your commit, maybe you know whats wrong with registerStringProtocol method ?

@codebytere
Copy link
Member

Duplicate of #28407

@codebytere codebytere marked this as a duplicate of #28407 Apr 8, 2021
@mahnunchik
Copy link
Contributor Author

@codebytere are you sure that it is related with #28407 ? In my case app crashes after click and handle the custom protocol link.

@pfrazee
Copy link
Contributor

pfrazee commented Apr 12, 2021

No idea if it's the same issue, I was working with pretty limited understanding. I detailed everything I knew/understood in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants