Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update extract-zip to 2+ #30155

Closed
jimmywarting opened this issue Jul 15, 2021 · 5 comments
Closed

update extract-zip to 2+ #30155

jimmywarting opened this issue Jul 15, 2021 · 5 comments
Labels

Comments

@jimmywarting
Copy link

extract-zip major changes was to convert it to a promise based version

So no need to wrap it ourself...

electron/npm/install.js

Lines 69 to 82 in 7169734

// unzips and makes path.txt point at the correct executable
function extractFile (zipPath) {
return new Promise((resolve, reject) => {
extract(zipPath, { dir: path.join(__dirname, 'dist') }, err => {
if (err) return reject(err);
fs.writeFile(path.join(__dirname, 'path.txt'), platformPath, err => {
if (err) return reject(err);
resolve();
});
});
});
}

@codebytere
Copy link
Member

Thanks for reaching out!

Because we treat our issues list as the team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Electron there are a lot of options.
Check out the Electron community. There are also a bunch of helpful people in this Discord that should be willing to point you in the right direction.

@miniak
Copy link
Contributor

miniak commented Sep 8, 2021

@codebytere we should have probably kept this one. It's a good suggestion and actually a task to do. https://github.com/maxogden/extract-zip/releases/tag/v2.0.0

@codebytere codebytere reopened this Sep 8, 2021
@codebytere codebytere assigned codebytere and unassigned codebytere Sep 8, 2021
@codebytere
Copy link
Member

@jimmywarting or @miniak could we update the template to be properly filled out?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@codebytere
Copy link
Member

Done in #34166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants