New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update extract-zip to 2+ #30155
Comments
Thanks for reaching out! Because we treat our issues list as the team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Electron there are a lot of options. |
@codebytere we should have probably kept this one. It's a good suggestion and actually a task to do. https://github.com/maxogden/extract-zip/releases/tag/v2.0.0 |
@jimmywarting or @miniak could we update the template to be properly filled out? |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Done in #34166 |
extract-zip major changes was to convert it to a promise based version
So no need to wrap it ourself...
electron/npm/install.js
Lines 69 to 82 in 7169734
The text was updated successfully, but these errors were encountered: