Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No range with registerStreamProtocol #30924

Closed
3 tasks done
vbourgeois opened this issue Sep 13, 2021 · 6 comments
Closed
3 tasks done

[Bug]: No range with registerStreamProtocol #30924

vbourgeois opened this issue Sep 13, 2021 · 6 comments

Comments

@vbourgeois
Copy link

Preflight Checklist

Electron Version

14.0.0

What operating system are you using?

Other Linux

Operating System Version

Mint 19.3

What arch are you using?

x64

Last Known Working Electron version

6.1.12

Expected Behavior

Hello,

I have registered a custom protocol with registerStreamProtocol in order to read offline audios and videos in my app. When I'm trying to "navigate" through the video I'm expecting to receive a range header in order to properly read the video stream with nodejs.

Actual Behavior

But I'm not receiving any range header in the request...

Here is an example of the issue :
Peek 10-09-2021 10-25

Here is what I'm receiving in the request :

{
    method: 'GET',
    url: 'lls-encrypted-stream://pages/6070955/ANG.2de.16.ACT1.The.Queen.mp4',
    referrer: 'http://localhost:9080/',
    headers: {
      'User-Agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.58 Electron/14.0.0 Safari/537.36',
      Range: 'bytes=0-',
      'Accept-Encoding': 'identity;q=1, *;q=0',
      Accept: '*/*'
    }
  }

=> lls-encrypted-stream:// is my custom protocol and you can see that the range is not properly set.

Last time it was working correctly was in electron 6.x

You can see the historic of the bug in this issue : #21018

Testcase Gist URL

No response

Additional Information

No response

@Koppel-Zhou
Copy link

I have the same problem when I use registerBufferProtocol in Electron 11 version or later, I can't control my video.

@dsanders11
Copy link
Member

@vbourgeois, could you provide a minimal reproduce case for this?

Also, are you registering lls-encrypted-stream as a privileged scheme with stream: true as one of the privileges?

@nathanbabcock
Copy link

Seems this is still an issue. Range headers don't work. BTW I am using both registerSchemesAsPriveleged and stream: true. Normal video loading works ok, but seeking the video does not.

Is there any workarounds for this or plans to fix? If there's bandwidth to look into it, I'm sure I could create a minimal reproduction in a repo.

@vbourgeois
Copy link
Author

@vbourgeois, could you provide a minimal reproduce case for this?

I don't have a lot of time to provide a reproduce case now. I'll try to do it in few days if I can.

Also, are you registering lls-encrypted-stream as a privileged scheme with stream: true as one of the privileges?

Yes and it didn't resolve the issue.

Is there any workarounds for this or plans to fix?

I'm using an express server to stream video & sound in Electron now.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 10, 2023
@github-actions
Copy link
Contributor

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants