Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Backport fix for text input performance regression to v16 #32239

Closed
3 tasks done
chase opened this issue Dec 17, 2021 · 2 comments
Closed
3 tasks done

Comments

@chase
Copy link
Contributor

chase commented Dec 17, 2021

Preflight Checklist

Problem Description

This bug has been fixed in Chromium 97, but it has massive impact on performance when using any sort of large input field, most noticeable in rich text fields: https://bugs.chromium.org/p/chromium/issues/detail?id=1271918

Related issues:
https://discuss.prosemirror.net/t/performance-issue-with-chrome-v96/4208
ianstormtaylor/slate#4699
https://jira.atlassian.com/browse/CONFCLOUD-73213

Proposed Solution

The fix is this commit: https://chromium.googlesource.com/chromium/src/+/d5496a43253193e7aefc658e4fde871ec146542b

It simply reverts: https://chromium.googlesource.com/chromium/src/+/4f6e94d8d4e491c1119b447fe530450684ea701e

Alternatives Considered

Wait for the next stable release.

Additional Information

No response

@VerteDinde VerteDinde added this to Unsorted Issues in 17-x-y Dec 19, 2021
@codebytere codebytere moved this from Unsorted Issues to Does Not Block Stable in 17-x-y Jan 5, 2022
@jkleinsc
Copy link
Contributor

jkleinsc commented Jan 5, 2022

@jkleinsc
Copy link
Contributor

Closing this issue as all affected branches have the fix applied.

@codebytere codebytere moved this from Does Not Block Stable to Fixed For Next Release in 17-x-y Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
17-x-y
Fixed For Next Release
Development

No branches or pull requests

3 participants