Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cancelling print causes electron to crash #32684

Closed
3 tasks done
t57ser opened this issue Jan 31, 2022 · 2 comments · Fixed by #32632
Closed
3 tasks done

[Bug]: Cancelling print causes electron to crash #32684

t57ser opened this issue Jan 31, 2022 · 2 comments · Fixed by #32632
Labels
bug 🪲 platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@t57ser
Copy link
Contributor

t57ser commented Jan 31, 2022

Preflight Checklist

Electron Version

17.0.0-beta.9

What operating system are you using?

Windows

Operating System Version

Windows 10 19042.985

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

No crash should happen, print gets cancelled

Actual Behavior

Calling window.print() and then clicking on the cancel button crashes electron

Testcase Gist URL

No response

Additional Information

No response

@VerteDinde
Copy link
Member

Hey @t57ser, thanks for reporting this issue! We have a PR in flight to fix this issue: #32632

I'll close this issue once that PR is landed and backported into 17 🙇‍♀️

@siebertm
Copy link

@VerteDinde this has not yet been backported to 17, shall this be reopened? That issue is blocking a release or ours, as our customers kinda want to print stuff all the time 🤷

Anything I can do to help / speed this up? (I dont trust my C++ enough for handling electron codebase though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants