Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: transition between minimized / maximized frameless window used to be smooth in 16.0.8; is no longer smooth in 17.0.1 #33210

Closed
3 tasks done
DogFoxX opened this issue Mar 9, 2022 · 3 comments
Labels

Comments

@DogFoxX
Copy link

DogFoxX commented Mar 9, 2022

Preflight Checklist

Electron Version

17.1.0

What operating system are you using?

Windows

Operating System Version

Windows 10 21H2

What arch are you using?

x64

Last Known Working Electron version

16.0.8

Expected Behavior

Frameless window maximizing and minimizing should be smooth

Actual Behavior

I'm not sure on which version of electron this started, but I updated from v16.0.8 to 17.0.1.
I'm using a frameless window with custom minimize, maximize and close buttons.
When the window is maximized or minimized, there is no longer a smooth transition.

Testcase Gist URL

No response

Additional Information

No response

@ckerr ckerr changed the title [Bug]: [Bug]: transition between minimized / maximized frameless window used to be smooth in 16.0.8; is no longer smooth in 17.0.1 Mar 9, 2022
@ckerr
Copy link
Member

ckerr commented Mar 9, 2022

Thanks for reporting this and helping to make Electron better!

Please use Electron Fiddle to create a standalone (no external dependencies) testcase and publish it as a gist, then link to it here.

  • Even if you have a code snippet or a git repository that show the testcase, please put it in a gist. This lets maintainers triage issues more effectively. It also ensures that we're testing the exact same issue that you're seeing!

  • Please avoid external dependencies in the test. The Electron team is small and generally doesn't have enough bandwidth to triage third-party code. Also, standalone tests are easier to adapt into regression tests.

  • If the bug you've found can be tested with a pass / fail test, please make the testcase exit 0 on success or nonzero on failure. The lets Electron's issue bot see what releases are affected by the bug.

I'm adding the blocked/need-repro label for this reason. After you make a test case, please link to the gist in a followup comment.

Thanks in advance! Your help is appreciated.

@ckerr ckerr added the blocked/need-repro Needs a test case to reproduce the bug label Mar 9, 2022
@t57ser
Copy link
Contributor

t57ser commented Mar 14, 2022

Seems like the same as: #32993

@mlaurencin
Copy link
Contributor

I agree, this looks like a duplicate of #32993. You may want to subscribe there for updates.

Because we treat our issues list as the project team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants