[Bug]: app_id not set when running Electron with native Wayland

[chrhasse]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

18.0.1

What operating system are you using?

Other Linux

Operating System Version

Arch Linux

What arch are you using?

x64

Last Known Working Electron version

18.0.0

Expected Behavior

The app_id window property should be set to the same value as class under X11.

Actual Behavior

app_id is an empty string when running Electron under Wayland.

Testcase Gist URL

No response

Additional Information

While most apps would crash prior to #33355, the default page if you run electron --ozone-platform=wayland would still run and properly set app_id.

[zcbenz]

/cc @p2004a

[p2004a]

I will try to reproduce and bisect the issue in the next couple of days.

[p2004a]

@chrhasse I have problem with reproducing this.

Using test app from https://www.electronjs.org/docs/latest/tutorial/quick-start

When I run electron version 18.0.0 under X11 I see that the WM_CLASS is set as application name my-electron-app. When I run on wayland I get:

$ WAYLAND_DEBUG=1 ELECTRON_ENABLE_LOGGING=true ~/Downloads/electron-v18.0.0-linux-x64/electron --ozone-platform=wayland test_app |& grep 'app_id'
[2507759.298]  -> xdg_toplevel@46.set_app_id("")

So the app_id is not set under wayland already under version 18.0.0 (I've not tested anything earlier then that).

[chrhasse]

Sorry, I think I must have made a mistake in my testing. I can't easily test older builds from this repository as they crash due to #32436 (for my system on Arch Linux with Sway 1.7), so I've been testing using my distro's packages. I had built 18.0.0 by modifying the PKGBUILD for 17.2.0, but I deleted the PKGBUILD and the package after my initial testing, and when I rebuilt it using a modified 18.0.1 PKGBUILD for convenience's sake, it wasn't setting the app_id. I'm not sure if I tested the wrong version initially or if it has to do with the package maintainer's patches (which can be found here). I can rebuild with a modified 17.2.0 PKGBUILD if I needed, but compilation takes me 2 and a half hours so I'd rather avoid it.

At any rate, if I downgrade to 17.2.0 from the Arch repositories and run:

$ WAYLAND_DEBUG=1 ELECTRON_ENABLE_LOGGING=true electron --ozone-platform=wayland |& grep 'app_id' 
[2615031.990]  -> xdg_toplevel@45.set_app_id("Electron")

The only version I can test from the GitHub releases is 13.6.9 which also properly sets app_id:

$ WAYLAND_DEBUG=1 ELECTRON_ENABLE_LOGGING=true ./electron --enable-features=UseOzonePlatform --ozone-platform=wayland |& grep 'app_id'
[2926405.757]  -> xdg_toplevel@35.set_app_id("Electron")

[p2004a]

Thanks, so the regression isn't between 18.0.0 and 18.0.1 but between 17 and 18 branches and is not related to my fixes.

I did git bisect on the main branch and 28ada6e is the first commit where app_id is not set, introducing this regression.

[enx1998]

Hi @p2004a, first of all thanks for your work.
Do you have any update on this issue? I start having applications without the name:

The one in the screenshot is Mattermost 5.1.0 which use Electron to v18.0.3.

Thanks ENx

[p2004a]

@enx1998 I'm not currently actively working on it, I've only verified that this is not caused by my changes.

[aslpavel]

New VSCode now has empty app_id as well, since it has switched to electron 18 :(

[andynd]

It would be even better to have a way to overwrite the app_id via the environment or a CLI option.
app_id is the only real way to differentiate windows under wayland if you are using a tiling window manager and want to pin some applications to some workspaces.
I've run into this problem with all sorts of electron apps and would realy love to have a single upstream fix which idealy results in a single option to set this value on all electron apps vs opening bugs at all the downstream projects using electron and getting 10 different solutions.