Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang in ConnectNamedPipe when using requestSingleInstanceLock #33736

Closed
nornagon opened this issue Apr 12, 2022 · 0 comments · Fixed by #33777
Closed

Hang in ConnectNamedPipe when using requestSingleInstanceLock #33736

nornagon opened this issue Apr 12, 2022 · 0 comments · Fixed by #33777

Comments

@nornagon
Copy link
Member

We are seeing a hang in ConnectNamedPipe on some machines with Electron 18 when a second instance launches:

Thread 0
 0  ntdll.dll!NtFsControlFile + 0x14
 1  KERNELBASE.dll!ConnectNamedPipe + 0x76
 2  slack.exe!static void `anonymous namespace'::SendBackAck() [process_singleton_win.cc : 204 + 0xf]
 3  slack.exe!base::OneShotTimer::FireNow() [timer.cc : 306 + 0x2c]
 4  slack.exe!void base::internal::DelayTimerBase::OnScheduledTaskInvoked(class std::__1::unique_ptr<base::internal::TaskDestructionDetector,std::__1::default_delete<base::internal::TaskDestructionDetector> >) [timer.cc : 283 + 0x10]
[...]

I believe this is due to #31460, which added the SendBackAck function. cc @rzhao271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants