[Bug]: Crash on Mac when viewDidBecomeFirstResponder

[mrchaofan]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

17.4.0

What operating system are you using?

macOS

Operating System Version

10.13.6

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

No crash.

Actual Behavior

A user of our app said that the app crashes frequently when first launched or when switching windows. We can't reproduce locally but the crashlog I added at additional information. I tried to change several lines of electron source code and send the new app to the user. He said he didn't meet crash so far.

The crash seems to be caused by a handle which called gfx::NativeView pointing to a nullptr and then call a method of the nullptr. But in objc, sending message to nil may be legal??? I'm not sure. I didn't take a formal programming class, I pretended to know JavaScript just for dinner😂😂😂

My changes:
mrchaofan@abe8c87

Testcase Gist URL

No response

Additional Information

guo.crashlog.txt

[mrchaofan]

I've noticed the pr #33063

We update electron from 16.0.8 to 17.4.0. It crashes too but crash at the next line of change.

[jkleinsc]

Thanks for reporting this and helping to make Electron better!

Based on your description above, I am not sure this is possible, but would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? Electron Fiddle is a great tool for making small testcases and publishing them as gists that Electron maintainers can use.

If the bug you've found can be tested with a pass / fail test, please make the testcase exit 0 on success or nonzero on failure. The lets Electron's issue bot see what releases are affected by the bug by checking your test against different OSes and Electron versions.

I'm adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment.

Thanks in advance! Your help is appreciated.

[mrchaofan]

Thank you. I can't reproduce locally. The crashlog is reported from a client computer and the user is the only user met the problem. We have 200,000 daily active users. I close the issue if I can reproduce it or have new progress, I'll open it.