Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: description of first-instance-ack event in Electron 18.0.0 blog is opposite to the PR #31460 #34478

Closed
3 tasks done
sriting opened this issue Jun 8, 2022 · 2 comments
Closed
3 tasks done

Comments

@sriting
Copy link

sriting commented Jun 8, 2022

Preflight Checklist

Electron Version

18.0.0

What operating system are you using?

macOS

Operating System Version

Mac OS

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

In Electron 18.0.0 blog, it said that:

Added first-instance-ack event to the app.requestSingleInstanceLock() flow, so that users can pass some data back from the second instance to the first instance.

image

While there is an opposite description in PR #31460:

The new ackCallback parameter allows the first instance to pass back some data to the second instance.

image

Actual Behavior

The description of first-instance-ack in Electron 18 blog should be same with the PR #31460.

Testcase Gist URL

No response

Additional Information

No response

@sriting sriting changed the title [Bug]: first-instance-ack event has opposite description in Electron 18.0.0 blog [Bug]: description of first-instance-ack event in Electron 18.0.0 blog is opposite to the PR #31460 Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants