New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Please fix the webview docs #34678
Comments
This bug was caused by a "kinda undocumented" electron 15 breaking change see: https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-150 and: electron/electron#31117 and: electron/electron#34678
hey I would like to work on this project can I get started? |
For visibility. @miniak made related changes in the following PRs:
I guess the only missing thing to close this issue is to update the document. However, Can someone point to an example of how this is usually done? |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Hey, I would like to work on this project, how can I start? |
I would like to work on this issue, please assign me this issue to resolve. |
@Michael-py001 I believe the issue is resolved as the event has been removed and documentation updated. |
Hello, |
This
The issue is closed already and updated i think |
Preflight Checklist
Electron Version
19.0.5
What operating system are you using?
Windows
Operating System Version
Windows 10
What arch are you using?
x64
Last Known Working Electron version
13.0.0
Expected Behavior
When I update electron from 13.0.0 to 19.0.5 ,webview's new-window event will not be triggered when I click a new url.
I searched a lot of docs and issues to find this answer . I finally found some discussions in #31117。
In docs https://www.electronjs.org/docs/latest/api/web-contents#event-new-window-deprecated
Event: 'new-window' has been deprecated, but there is no any notices or declarations in webview docs: https://www.electronjs.org/docs/latest/api/webview-tag , this is so confused me. Please fix the docs.
Actual Behavior
Please fix the webview docs, add some declarations about event: 'new-window' has been deprecated.
Testcase Gist URL
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: