Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The setAsDefaultProtocolClient() converts all arguments from array in the single line #35021

Closed
3 tasks done
MaksimDedov opened this issue Jul 21, 2022 · 1 comment
Closed
3 tasks done
Labels

Comments

@MaksimDedov
Copy link

Preflight Checklist

Electron Version

17.0.0

What operating system are you using?

Windows

Operating System Version

Windows 11

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

When executing the code below:

const appArgs = ["--arg1=1", "--arg2=2"];
app.setAsDefaultProtocolClient("prefix", process.execPath, appArgs);

all arguments from the array should be separated
The row in the Regedit should look like this:
"{path to .exe}" "--arg1=1" "--arg2=2" "%1"

Actual Behavior

The actual row in the Regedit is
"{path to .exe}" "--arg1=1 --arg2=2" "%1"

That's why the second instance of Electron couldn't rise up for me

Testcase Gist URL

No response

Additional Information

No response

@mesner
Copy link
Contributor

mesner commented Jul 22, 2022

Fixed in #32953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants