Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: fix crashReport.start has been reverted #35592

Closed
3 tasks done
becauseOf opened this issue Sep 7, 2022 · 1 comment
Closed
3 tasks done

[Bug]: fix crashReport.start has been reverted #35592

becauseOf opened this issue Sep 7, 2022 · 1 comment
Labels

Comments

@becauseOf
Copy link

Preflight Checklist

Electron Version

^20.1.1

What operating system are you using?

macOS

Operating System Version

monterey

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

crashReport.start quick

Actual Behavior

crashReport.start still slow

Testcase Gist URL

No response

Additional Information

#34609

@RaisinTen
Copy link
Member

There was also a reland right after the revert - https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3721655 and that change still exists.

And Electron is maintaining a patch file containing the performance fix in v20.1.1 - https://github.com/electron/electron/blob/v20.1.1/patches/chromium/posix_replace_doubleforkandexec_with_forkandspawn.patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants