Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WebAssembly.{compileStreaming|instantiateStreaming} in Node.js #36282

Closed
codebytere opened this issue Nov 8, 2022 · 0 comments · Fixed by #36420
Closed

Enable WebAssembly.{compileStreaming|instantiateStreaming} in Node.js #36282

codebytere opened this issue Nov 8, 2022 · 0 comments · Fixed by #36420
Assignees
Labels
component/node-integration upgrade-follow-up Stuff left to do after a Chromium upgrade.

Comments

@codebytere
Copy link
Member

Refs #35999.

Refs nodejs/node#42701.

Node.js added support for WebAssembly.compileStreaming and WebAssembly.instantiateStreaming but they don't work within Electron at the moment.

This is happening because Node.js' logic for enabling them here is called via node::SetIsolateUpForNode, which by necessity can only be called on an existing isolate. However, the switch to enable it here is called by gin during its own isolate initialization, which means that it ends up being undefined. Look into a good way to fix this.

@codebytere codebytere added component/node-integration upgrade-follow-up Stuff left to do after a Chromium upgrade. labels Nov 8, 2022
@codebytere codebytere self-assigned this Nov 8, 2022
@codebytere codebytere changed the title Enable `WebAssembly.{compileStreaming|instantiateStreaming} in Node.js Enable WebAssembly.{compileStreaming|instantiateStreaming} in Node.js Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/node-integration upgrade-follow-up Stuff left to do after a Chromium upgrade.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant