Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Window transparency is not restored when a maximised video is unmaximised #38244

Closed
3 tasks done
SilverBirchh opened this issue May 10, 2023 · 6 comments
Closed
3 tasks done

Comments

@SilverBirchh
Copy link

Preflight Checklist

Electron Version

24.2.0

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.6.5

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

With an app that has a transparent area if you maximise a video element to view it full screen and then minimise the transparent area should stay transparent.

Actual Behavior

With an app that has a transparent area if you maximise a video element to view it full screen and then minimise the transparent area turns solid.

Screen.Recording.2023-05-10.at.12.12.25.mov

Testcase Gist URL

https://gist.github.com/SilverBirchh/8e4e4c92e0b3759f0f9d8fc2ef599bd2

Additional Information

Sorry if this has already been fixed! I couldn't find anything else

Repo https://github.com/SilverBirchh/electron-video-test

@SilverBirchh SilverBirchh changed the title [Bug]: Window transparency is not restored when a maximised video is minimised [Bug]: Window transparency is not restored when a maximised video is unmaximised May 10, 2023
@georgexu99
Copy link
Contributor

georgexu99 commented May 16, 2023

Managed to bisect this to 16.0.8! I'll havn't looked in-depth into the issue, but this [PR] (https://github.com/electron/electron/pull/32648/files) as well as this issue may be related

@SilverBirchh
Copy link
Author

this issue may be related

fwiw that is the hack we're using to get around this issue. when the video is un-maximised we're changing the window size by a pixel and back again. Doesn't always work but 90% of the time it does

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Aug 17, 2023
@SilverBirchh
Copy link
Author

bump

@github-actions github-actions bot removed the stale label Aug 19, 2023
@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@electron-issue-triage
Copy link

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@electron-issue-triage electron-issue-triage bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Unsorted Items
Development

No branches or pull requests

3 participants