Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Image captured on light mode sites composited to black background - unreadable #39368

Open
3 tasks done
renambot opened this issue Aug 3, 2023 · 8 comments
Open
3 tasks done
Labels
25-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/

Comments

@renambot
Copy link

renambot commented Aug 3, 2023

Preflight Checklist

Electron Version

25.x

What operating system are you using?

macOS

Operating System Version

macOS Ventura 13.5

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

No response

Expected Behavior

Captured images through contents.beginFrameSubscription returns a ARGB NativeImage I believe, when converted to JPEG (.toJPEG(quality)) should be flatten on a white background or configurable color.

Actual Behavior

Captured images through contents.beginFrameSubscription returns a ARGB NativeImage I believe, when converted to JPEG (.toJPEG(quality)) is flatten on a black background, which makes it unreadable.

This happens on 'light mode' sites like the Electron docs and many others:

Screenshot 2023-08-03 at 5 12 19 PM

Testcase Gist URL

No response

Additional Information

No response

@VerteDinde VerteDinde added the blocked/need-repro Needs a test case to reproduce the bug label Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Hello @renambot. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@renambot
Copy link
Author

renambot commented Aug 4, 2023

Here's an electron fiddle test case:

https://gist.github.com/renambot/a1e6ec4e81bcb2e50f15d92948dba8ff

@github-actions github-actions bot removed the blocked/need-repro Needs a test case to reproduce the bug label Aug 4, 2023
@renambot
Copy link
Author

Still there on Electron v26.0.0 on macOS

@jkleinsc jkleinsc added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 25-x-y labels Aug 21, 2023
@renambot
Copy link
Author

Still there on Electron v27.0.0 on macOS

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@renambot
Copy link
Author

Still there on 28.1.3 macOS

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@renambot
Copy link
Author

Still there on 30.0.0 macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/
Projects
No open projects
Status: Unsorted Items
Development

No branches or pull requests

3 participants