Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Enable preloads in iframes without node integration #40646

Open
3 tasks done
rhysbrettbowen opened this issue Nov 29, 2023 · 0 comments
Open
3 tasks done

Comments

@rhysbrettbowen
Copy link

rhysbrettbowen commented Nov 29, 2023

Preflight Checklist

Problem Description

#16425 allows preloads for iframes, but only if nodeIntegrationInSubFrames is set to true. We would like to keep node integration off but allow us to run preloads in iframes.

Proposed Solution

create a new flag preloadInSubFrames to allow running just the preload without node integration

Alternatives Considered

use https://www.electronjs.org/docs/latest/api/web-frame-main to get a handle on web contents and inject through javascript. However does not have nice things like context isolation and exposeInMainWorld

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant