Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Frameless windows don't have drop shadow on Wayland #39664

Closed
3 tasks done
aiddya opened this issue Aug 26, 2023 · 3 comments · May be fixed by #41840
Closed
3 tasks done

[Bug]: Frameless windows don't have drop shadow on Wayland #39664

aiddya opened this issue Aug 26, 2023 · 3 comments · May be fixed by #41840
Labels

Comments

@aiddya
Copy link
Contributor

aiddya commented Aug 26, 2023

Preflight Checklist

Electron Version

26.1.0

What operating system are you using?

Other Linux

Operating System Version

Fedora 38

What arch are you using?

x64

Last Known Working Electron version

none

Expected Behavior

Create a BrowserWindow with frame set to false. The window should have a drop shadow.

Actual Behavior

The window has a drop shadow with --ozone-platform=x11, but none with --ozone-platform=wayland.

Testcase Gist URL

No response

Additional Information

ClientFrameViewLinux needs to be updated to draw just shadows without a GTK frame and this case should be handled in ElectronDesktopWindowTreeHostLinux::UpdateFrameHints().

@mlaurencin mlaurencin added the blocked/need-repro Needs a test case to reproduce the bug label Aug 28, 2023
@github-actions
Copy link
Contributor

Hello @aiddya. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@electron-issue-triage
Copy link

Unfortunately, without a way to reproduce this issue, we're unable to continue investigation. This issue has been closed and will not be monitored further. If you're able to provide a minimal test case that reproduces this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@electron-issue-triage electron-issue-triage bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2023
@electron-issue-triage electron-issue-triage bot removed the blocked/need-repro Needs a test case to reproduce the bug label Sep 8, 2023
@DaVarga
Copy link

DaVarga commented Dec 2, 2023

Why is this closed? This bug still exist. For example VSCode is affected by it. Starting VSCode with --ozone-platform=x11 does show a window shadow - lunching with --ozone-platform=wayland does not.
Providing that window.titleBarStyle is set to custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants