perf: remove unnecessary .c_str()
calls
#41869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Minor perf cleanup for cases where we have a string or wstring
foo
and pass it to a method that takes astd::string_view
withfoo.c_str()
instead of justfoo
. Passing the string is preferable since its length is already known and won't have to be recomputed from theconst char*
.All reviews welcome; no specific individual stakeholders.
Checklist
npm test
passesRelease Notes
Notes: none.