Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make corrections for BrowserViews since it is deprecated #42030

Merged
merged 1 commit into from May 8, 2024
Merged

docs: make corrections for BrowserViews since it is deprecated #42030

merged 1 commit into from May 8, 2024

Conversation

xupea
Copy link
Contributor

@xupea xupea commented May 3, 2024 •
edited by nornagon

Description of Change

seems WebContentsView is the right option instead of BrowserView according to context, and BrowserView is deprecated.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels May 3, 2024
erickzhao
erickzhao approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer bot approved these changes May 6, 2024
View reviewed changes
Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@erickzhao
Copy link
Member

cc @nornagon

@codebytere codebytere added target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. labels May 8, 2024
@codebytere codebytere merged commit 0128a07 into electron:main May 8, 2024
33 checks passed
@release-clerk Release Clerk
Copy link

release-clerk bot commented May 8, 2024

No Release Notes

This was referenced May 8, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 8, 2024

I have automatically backported this PR to "30-x-y", please check out #42083

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels May 8, 2024
@trop
Copy link
Contributor

trop bot commented May 8, 2024

I have automatically backported this PR to "31-x-y", please check out #42084

@trop trop bot added in-flight/31-x-y merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. in-flight/30-x-y in-flight/31-x-y labels May 8, 2024
Mrnikifabio pushed a commit to Mrnikifabio/electron that referenced this pull request May 14, 2024
@xupea @Mrnikifabio
docs: make corrections for BrowserViews since it is deprecated (elect…
9a52fa0 
…ron#42030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xupea @erickzhao @nornagon @codebytere