feat: BrowserWindow.getNormalBounds()

[emmkimme]

• Electron version: master branch
• Operating system: All

When you have to serialize a layout of windows : position, size, state and visibility. If the window is in ‘maximized’ or ‘full-screen’ state, you have no way to get its bounds when restored.
Purpose is to add a function which, whatever the state of window, returns the bounds of the window in normal state.

Proposal

 BrowserWindow.getBormalBounds(): Rectangle

Returns Rectangle - Contains the window bounds of the normal state

Expected Behavior

 const w = new BrowserWindow({
    width: 400,
    height: 400
  })
 assertBoundsEqual(w.getBounds(),w.getNormalBounds())
 const normalBounds = w.getBounds();

  w.once('maximize', () => {
    assertBoundsEqual(w.getNormalBounds(),normalBounds)
  })
  w.maximize()

Note : I have been hesitating for a long time between getNormalBounds and getRestoredBounds (name of the internal Chromium function). But we are used to talk of minimized, maximized, full-screen and normal state (not restored or unmaximized) so I choose normal. Feel free to challenge this.

Notes: Added a getNormalBounds() API to the BrowserWindow class to fetch window bounds while minimized.

[codebytere]

Small typo to correct but i won't block on it; thanks for adding this, it looks great! However, your testing might need some correction as it's failing on timeout at present. See this build for details, and perhaps try running them individually to pinpoint the cause?

[codebytere]

tiny typo here
getBormalBounds() => getNormalBounds()

[emmkimme]

Thanks for the typo. It realized some features are not well supported in CI and skipped in automatic tests (maximize, minimize, fullscreen). This is not always consistent, sometimes according to CI mode, sometimes according to OS. I will have a look at.

[poiru]

Nit: lowercase i here.

[emmkimme]

Last remaining check issue seems not related to my MR.

[release-clerk]

Release Notes Persisted

Added a getNormalBounds() API to the BrowserWindow class to fetch window bounds while minimized.