Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add screen reader support to Win32 toast notifications #13834

Merged
merged 1 commit into from Sep 12, 2018
Merged

feat: add screen reader support to Win32 toast notifications #13834

merged 1 commit into from Sep 12, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 27, 2018 •
edited

Description of Change

Implement missing accessibility support via UIAutomation

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: Implemented missing accessibility support via UIAutomation for Windows 7 toasts.

@miniak miniak requested review from a team July 27, 2018 17:03
@miniak miniak changed the title Add screen reader support to Win32 toast notifications feat: add screen reader support to Win32 toast notifications Jul 27, 2018
@miniak miniak requested a review from alespergl July 27, 2018 17:04
@miniak miniak force-pushed the miniak/toast-accessibility branch from 8edbfaf to 6c0e783 Compare July 27, 2018 17:05
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Aug 28, 2018 •
edited

@miniak Can you please fix linting errors?

@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Aug 28, 2018 •
edited

Implement missing accessibility support via UIAutomation

So is it a feature or a bug fix? )
If it is a feature, then it can't go to the 3.0.x release line.

@alexeykuzmin
Copy link
Contributor

@miniak Can you please rebase this branch onto the latest master to run GN builds with all the latest changes?

@miniak miniak self-assigned this Sep 3, 2018
@chandrakanthi07
Copy link

Hi
I wanted to know whether this feature is anyway related to desktopcapturing when screen is locked in win 32 machine.
Because right not we are not getting screenshots when screen is locked.

@miniak
Copy link
Contributor Author

miniak commented Sep 4, 2018 •
edited

@chandrakanthi07 what makes you think it's related? This is an accessibility issue.

@miniak
Copy link
Contributor Author

miniak commented Sep 4, 2018

@alexeykuzmin the problem is that those headers must be included in a certain order (because Windows). @alespergl can you help here?

@miniak
Copy link
Contributor Author

miniak commented Sep 4, 2018

@alexeykuzmin linting fixed

@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Sep 4, 2018 •
edited

@miniak

brightray/browser/win/win32_desktop_notifications/toast.cc(328,9):  
  error: [chromium-style] auto variable type must not deduce to a raw pointer type.
        auto inst = Get(hwnd);
        ^~~~
        auto*

@miniak miniak force-pushed the miniak/toast-accessibility branch 2 times, most recently from c696f39 to 95252f8 Compare September 4, 2018 20:42
@miniak
Copy link
Contributor Author

miniak commented Sep 5, 2018

@alexeykuzmin all build issues should be fixed

@MarshallOfSound MarshallOfSound changed the title feat: add screen reader support to Win32 toast notifications feat: add screen reader support to Win32 toast notification Sep 6, 2018
@MarshallOfSound MarshallOfSound changed the title feat: add screen reader support to Win32 toast notification feat: add screen reader support to Win32 toast notifications Sep 6, 2018
@miniak miniak force-pushed the miniak/toast-accessibility branch 2 times, most recently from 79a4ecc to 14da1ca Compare September 9, 2018 11:40
@miniak
Copy link
Contributor Author

miniak commented Sep 9, 2018

@ckerr, @codebytere can you please merge?

@MarshallOfSound MarshallOfSound merged commit 932f6c8 into master Sep 12, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 12, 2018

Release Notes Persisted

Implemented missing accessibility support via UIAutomation for Windows 7 toasts.

@MarshallOfSound MarshallOfSound deleted the miniak/toast-accessibility branch September 12, 2018 14:18
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@alespergl alespergl alespergl approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @alexeykuzmin @chandrakanthi07 @codebytere @alespergl @MarshallOfSound