feat: Add electron version to framework

[groundwater]

Description of Change

Beginning with MacOS, we don't have an easy way to extract the Electron version from an application build. This can be handy for bulk scanning apps to determine if they're using a version of Electron with any exploits, and either remove, disable, update those apps.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR title follows semantic commit guidelines

Release Notes

Notes: Add Version key to Electron Framework bundle's Info.plist

[deepak1556]

Is this an accidental change ?

[groundwater]

yah, I was tracking another branch because originally the gn changes weren't in master yet. I'll update.

[deepak1556]

I believe CFBundleVersion from atom/browser/resources/mac/Info.plist already solves this ?

[groundwater]

@deepak1556 where does that get copied to?

[deepak1556]

Info.plist under the app Contents folder.

[groundwater]

@deepak1556 at least in the case for Slack, and VS Code those Info.plist files are replaced on distribution. If we place it into the framework, we can separate the version of Electron from the version of the app being distributed.

Should I rename it CFBundleVersion?

[malept]

at least in the case for Slack, and VS Code those Info.plist files are replaced on distribution.

Confirmed, Electron Packager replaces Content/Info.plist's CFBundleVersion with either the build version or the app version (depending on what's defined):

https://github.com/electron-userland/electron-packager/blob/a49c08de260e3d81c928608e08ba4d2a7d65f425/mac.js#L195-L201

[deepak1556]

@groundwater @malept Thanks for the clarification!

Should I rename it CFBundleVersion?

Yup that should be good.

[deepak1556]

LGTM, can you update the file with gn format to fix style issues. Not a blocker for merging. Thanks!

[release-clerk]

Release Notes Persisted

Add Version key to Electron Framework bundle's Info.plist