From dfb42650e4f0c9789a732b1a0c476186629bc229 Mon Sep 17 00:00:00 2001
From: Jacob Groundwater <groundwater@gmail.com>
Date: Fri, 24 Aug 2018 10:33:57 -0700
Subject: [PATCH 1/2] Add electron version to framework

---
 BUILD.gn                             | 2 +-
 atom/common/resources/mac/Info.plist | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/BUILD.gn b/BUILD.gn
index 1a5e526dbd23f..5e9c613429e07 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -494,7 +494,7 @@ if (is_mac) {
       deps += [ ":electron_crashpad_helper" ]
     }
     info_plist = "atom/common/resources/mac/Info.plist"
-    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework" ]
+    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework", "ELECTRON_VERSION=$electron_version" ]
 
     include_dirs = [ "." ]
     sources = filenames_gypi.framework_sources
diff --git a/atom/common/resources/mac/Info.plist b/atom/common/resources/mac/Info.plist
index 7b56a46470ea0..ffbb30d463262 100644
--- a/atom/common/resources/mac/Info.plist
+++ b/atom/common/resources/mac/Info.plist
@@ -12,5 +12,7 @@
 	<string>FMWK</string>
 	<key>NSSupportsAutomaticGraphicsSwitching</key>
 	<true/>
+	<key>Version</key>
+	<string>${ELECTRON_VERSION}</string>
 </dict>
 </plist>

From 30bec5442a5904f8ec70f72a0b3a3a1de5289b8f Mon Sep 17 00:00:00 2001
From: Jacob Groundwater <groundwater@github.com>
Date: Mon, 27 Aug 2018 08:45:30 -0700
Subject: [PATCH 2/2] Update Info.plist

---
 atom/common/resources/mac/Info.plist | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/atom/common/resources/mac/Info.plist b/atom/common/resources/mac/Info.plist
index ffbb30d463262..26abfe04ca890 100644
--- a/atom/common/resources/mac/Info.plist
+++ b/atom/common/resources/mac/Info.plist
@@ -12,7 +12,7 @@
 	<string>FMWK</string>
 	<key>NSSupportsAutomaticGraphicsSwitching</key>
 	<true/>
-	<key>Version</key>
+	<key>CFBundleVersion</key>
 	<string>${ELECTRON_VERSION}</string>
 </dict>
 </plist>