feat: add event.senderId property to IPCs sent via ipcRenderer.sendTo #14395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
requested review from
a team,
MarshallOfSound,
ckerr,
codebytere,
deepak1556 and
alexeykuzmin
miniak
force-pushed
the
miniak/sender-id
branch
5 times, most recently
from
fca3fc7
to
618de55
Compare
| @@ -41,7 +41,7 @@ void RemoteCallbackFreer::RunDestructor() { | |||
| auto* frame_host = web_contents()->GetMainFrame(); | |||
| if (frame_host) { | |||
| frame_host->Send(new AtomFrameMsg_Message(frame_host->GetRoutingID(), false, | |||
| channel, args)); | |||
| channel, args, 0)); | |||
There was a problem hiding this comment.
<...>, args, /* sender_id */ 0));| const {ipcRenderer} = require('electron') | ||
| ipcRenderer.on('ping', function (event, id) { | ||
| ipcRenderer.sendTo(id, 'pong', id) | ||
| ipcRenderer.on('ping', function (event, payload) { |
There was a problem hiding this comment.
ipcRenderer is probably undefined here.
There was a problem hiding this comment.
it's exposed by the preload script
There was a problem hiding this comment.
preload: path.join(fixtures, 'module', 'preload-inject-ipc.js'),
miniak
force-pushed
the
miniak/sender-id
branch
from
618de55
to
7315354
Compare
miniak
force-pushed
the
miniak/sender-id
branch
from
7315354
to
79ad682
Compare
alexeykuzmin
approved these changes
Aug 31, 2018
ckerr
reviewed
Aug 31, 2018
| bool SendIPCMessageWithSender(bool all_frames, | ||
| const std::string& channel, | ||
| const base::ListValue& args, | ||
| int32_t sender_id = 0); |
There was a problem hiding this comment.
Why not add this default fourth arg to SendIPCMessage() instead of adding a new function -- do we need both functions?
There was a problem hiding this comment.
It does not work for methods exposed to JS via mate. The default arguments are ignored. It has to be a separate method unfortunatelly
ckerr
approved these changes
Sep 1, 2018
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently, it's not possible to tell whether an IPC was sent directly from the main process or from another renderer via
renderer.sendTo. This PR addsevent.senderIdproperty, which identifies the originating webContents. If the IPC was sent directly from the main process, the value is 0.The modified
spec/api-ipc-renderer-spec.jsdemonstrates this.Checklist
npm testpassesRelease Notes
Notes: Added
event.senderIdproperty to IPCs sent viaipcRenderer.sendTo.