Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address TODO for app.makeSingleInstance / releaseSingleInstance removal #14518

Merged
merged 1 commit into from Sep 10, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 9, 2018

Description of Change
// TODO(MarshallOfSound): Remove in 4.0
app.releaseSingleInstance = () => {
  deprecate.warn('app.releaseSingleInstance(cb)', 'app.releaseSingleInstanceLock()')
  app.releaseSingleInstanceLock()
}

// TODO(MarshallOfSound): Remove in 4.0
app.makeSingleInstance = (oldStyleFn) => {
  deprecate.warn('app.makeSingleInstance(cb)', 'app.requestSingleInstanceLock() and app.on(\'second-instance\', cb)')
  if (oldStyleFn && typeof oldStyleFn === 'function') {
    app.on('second-instance', (event, ...args) => oldStyleFn(...args))
  }
  return !app.requestSingleInstanceLock()
}
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@MarshallOfSound MarshallOfSound merged commit dcd580b into master Sep 10, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 10, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants