Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Chromium 68.0.3440.128 and Node 10.11.0 #14964

Merged
merged 51 commits into from Oct 4, 2018
Merged

feat: upgrade to Chromium 68.0.3440.128 and Node 10.11.0 #14964

merged 51 commits into from Oct 4, 2018

Conversation

MarshallOfSound
Copy link
Member

This is a reland due to an accidental squash-and-merge

Description of Change

Upgrade to Chromium 68.0.3440.128 and Node 10.11.0.
BREAKING CHANGE

Board: https://github.com/orgs/electron/projects/23

Checklist
  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Upgrade to Chromium 68.0.3440.128 and Node 10.11.0

NOTE: process.setFdLimit will now only ever increase the fd limit, see chromium@6f2ff42cfc2

@nornagon @alexeykuzmin
Update to Chromium 68.0.3440.128 and Node 10.10.0
78c8951
@nornagon @alexeykuzmin
bump CHROME_VERSION_STRING
d5e9b66 
TODO: automatically pull in the real chrome version
@nornagon @alexeykuzmin
update v8, ffmpeg, chromium, crashpad, boringssl, and webrtc patches
6f2f761
@nornagon @alexeykuzmin
fix SSL_get_tlsext_status_type patch
e721388
@nornagon @alexeykuzmin
pass encryption_modes_supported to CdmInfo
ce2c8e3
@nornagon @alexeykuzmin
kNoSandbox moved into service_manager
7092fa3
@nornagon @alexeykuzmin
PathService -> base::PathService
de581ca
@nornagon @alexeykuzmin
net::X509Certificate::Equals -> net::X509Certificate::EqualsExcluding…
2804213 
…Chain
@nornagon @alexeykuzmin
use content::ChildProcessTerminationInfo
1c60f9e
@nornagon @alexeykuzmin
GetHandle() -> GetProcess().Handle()
b9cd349
@nornagon @alexeykuzmin
ScopedNestableTaskAllower doesn't take an argument
5a75744
@nornagon @alexeykuzmin
net::HttpAuthCache::ClearEntriesAddedWithin -> ClearAllEntries
8060e91
@nornagon @alexeykuzmin
std::unique_ptr<WebContents>
a5b09e2
@nornagon @alexeykuzmin
blink::WebFullscreenOptions
517d38f
@nornagon @alexeykuzmin
OnAudioStateChanged doesn't take a WebContents
948fe21
@nornagon @alexeykuzmin
content::RESULT_CODE_NORMAL_EXIT -> service_manager::RESULT_CODE_NORM…
08265ba 
…AL_EXIT
@nornagon @alexeykuzmin
MessageLoopCurrent
5d9ba8b
@nornagon @alexeykuzmin
WasResized -> SynchronizeVisualProperties
faf5768
@nornagon @alexeykuzmin
expose URLRequestContextGetter::{Add,Remove}Observer
9c15c97
@nornagon @alexeykuzmin
SetTimeStamp takes a base::TimeTicks
3b76573
@nornagon @alexeykuzmin
ExecuteScriptInIsolatedWorld is single-script only
7a043a8
@nornagon @alexeykuzmin
DispatchNonPersistentCloseEvent takes a callback now
7e5d90f
@nornagon @alexeykuzmin
test: remove no longer existing Chromium test deps
e6da87b 
cc_blink_unittests has been removed in
https://chromium-review.googlesource.com/1053765

mojo_common_unittests has been removed in
https://chromium-review.googlesource.com/1028000
@nornagon @alexeykuzmin
MessageLoop::QuitWhenIdleClosure -> RunLoop::QuitCurrentWhenIdleClosu…
f0da5bc 
…reDeprecated
@nornagon @alexeykuzmin
SetFdLimit -> IncreaseFdLimitTo
6a202c9 
NOTE: the behaviour of this API has changed slightly, and we should
mention that in the notes.
@nornagon @alexeykuzmin
certificate_transparency moved out of net/
3657715 
pending a clearer decision about what to do with CT

in the mean time, copy CreateLogVerifiersForKnownLogs from deleted chromium source
@nornagon @alexeykuzmin
add secure_origin_whitelist to chrome source list
5d882c6 
NOTE: is this something we actually want? cc @deepak1556
@nornagon @alexeykuzmin
DrainBackgroundTasks -> DrainTasks
9aaedc3
@nornagon @alexeykuzmin
use new node options parser
6e037f5
@nornagon @alexeykuzmin
fix disable_scroll_begin_dcheck.patch
2f75777
nornagon and others added 21 commits October 4, 2018 00:13
@nornagon @alexeykuzmin
ViewsDelegate::CreateWebContents went away
f9ed25d 
see https://chromium-review.googlesource.com/c/chromium/src/+/1031314
@nornagon @alexeykuzmin
kZygoteProcess moved into service_manager
4e679a3
@alexeykuzmin
test: minor improvements to the Node spec
ae95f77 
 - reformat some parts
 - better failures reporting with `expect`
 - skip some tests instead of marking them as passed
@nornagon @alexeykuzmin
chromium removed *_posix.cc from the source filters
aafe833
@alexeykuzmin
test: fix :electron_tests compilation
6ab5c2f
@nornagon @alexeykuzmin
better crash diagnostics in ffmpeg test
cc53269
@alexeykuzmin
fix: enable back a DCHECK in viz::ServerSharedBitmapManager
ae12d53 
Fixes #14327.
Backports https://chromium-review.googlesource.com/802574.
@nornagon @alexeykuzmin
test: fix frame-subscriber test on Mac
09f018c
@alexeykuzmin
chore: remove obsolete "install-sysroot.py" script
01179ea
@alexeykuzmin
chore: update linux sysroots
0fc79ad
@nornagon @alexeykuzmin
disable OSR for now
41d806e
@zcbenz @alexeykuzmin
test: make before-input-event test more robust
b11b4f2
@MarshallOfSound @alexeykuzmin
test: make run-as-node --inspect test more robust on windows
0ee46cd
@nornagon @alexeykuzmin
roll node to v10.11.0
d4c8375
@nornagon @alexeykuzmin
avoid duplicate files when building a zip
81bd7fa
@nornagon @alexeykuzmin
disable failing assert in beginFrameSubscription dirty-rectangle test
45c2dcd
@nornagon @alexeykuzmin
experiment with is_cfi = false
f7f93d2
@alexeykuzmin
fix: build torque with x64 toolchain
df32326 
Co-Authored-By: Alexey Kuzmin <github@alexeykuzmin.com>
@alexeykuzmin
test: disable the "app.relaunch" test on Linux
21f382f
@MarshallOfSound
chore: bump node to get header tar file
b47081e
@MarshallOfSound
chore: bump node to fix tar.py line endings
a78fff0
@MarshallOfSound MarshallOfSound requested review from a team October 4, 2018 02:04
@MarshallOfSound MarshallOfSound merged commit 03e6113 into master Oct 4, 2018
@release-clerk
Copy link

release-clerk bot commented Oct 4, 2018

Release Notes Persisted

Upgrade to Chromium 68.0.3440.128 and Node 10.11.0

@MarshallOfSound MarshallOfSound deleted the chromium-upgrade/68 branch October 4, 2018 02:05
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarshallOfSound @nornagon @alexeykuzmin @zcbenz