feat: upgrade to Chromium 69.0.3497.106 #14972

alexeykuzmin · 2018-10-04T15:02:30Z

Description of Change

Upgrade to Chromium 69.0.3497.106
BREAKING CHANGE

Board https://github.com/orgs/electron/projects/24

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines

Release Notes

Notes: Upgrade to Chromium 69.0.3497.106

KoenLav · 2018-10-04T21:02:44Z

The speed you guys (Electron) have taken up in keeping up with Chromium versions is incredible!

Do you know which version of Chromium is expected to land in 4.0?

nornagon · 2018-10-04T21:08:42Z

Do you know which version of Chromium is expected to land in 4.0?

Not yet. We have a go/no-go for M69 on Monday. It'll definitely be either M68 or M69. We'll know soon!

BUILD.gn

alexeykuzmin · 2018-10-08T08:41:40Z

BUILD.gn

    ]

    if (is_win) {
      sources += [
+        "//chrome/utility/printing_handler.cc",
+        "//chrome/utility/printing_handler.h",


@brenca sources should be sorted alphabetically, like any other lists in GN configs.
The linter job didn't report its results for some reason.

I had to fix the linter, it refused to run for me on Windows, thanks for catching this!

https://chromium-review.googlesource.com/c/chromium/src/+/1086949

https://chromium-review.googlesource.com/c/chromium/src/+/1093052

https://chromium-review.googlesource.com/c/chromium/src/+/1128194

https://chromium-review.googlesource.com/c/chromium/src/+/1108485

https://chromium-review.googlesource.com/c/chromium/src/+/1124200

https://chromium-review.googlesource.com/c/chromium/src/+/1087627

https://chromium-review.googlesource.com/c/chromium/src/+/1085568 https://chromium-review.googlesource.com/c/chromium/src/+/1085466

…profile https://chromium-review.googlesource.com/c/chromium/src/+/1114840

https://chromium-review.googlesource.com/c/chromium/src/+/1121957 https://chromium-review.googlesource.com/c/chromium/src/+/1037145

several CLs, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1092933

https://chromium-review.googlesource.com/c/chromium/src/+/1072643

https://chromium-review.googlesource.com/c/chromium/src/+/1102836

…elegate https://chromium-review.googlesource.com/c/chromium/src/+/1136858

https://chromium-review.googlesource.com/c/chromium/src/+/1085427

should be fixed and re-enabled before release

…nux-release-testing

nornagon

good to merge once CI is green

MarshallOfSound

Pending green CI

The compositor_superview member of BridgedNativeWidgetMac has been removed so as a consequence there is only one layer on which we need to call setBackgroundColor

release-clerk · 2018-10-10T04:29:25Z

Release Notes Persisted

Upgrade to Chromium 69.0.3497.106

KoenLav · 2018-10-11T13:46:07Z

@nornagon what was decided for 4.0?

ckerr · 2018-10-11T15:49:54Z

@KoenLav 4.0.0 will have Chromium 69

alexeykuzmin requested review from a team October 4, 2018 15:02

nornagon force-pushed the chromium-upgrade/69 branch 2 times, most recently from 41ab138 to b1dff19 Compare October 5, 2018 01:40

MarshallOfSound reviewed Oct 8, 2018

View reviewed changes

BUILD.gn Outdated Show resolved Hide resolved

alexeykuzmin commented Oct 8, 2018

View reviewed changes

brenca force-pushed the chromium-upgrade/69 branch from 4f48ede to 3f1c43e Compare October 8, 2018 17:36

nornagon added 19 commits October 9, 2018 14:37

roll Chromium to 69.0.3497.106

aefb891

update chromium and v8 patches

ef12492

//tools/gn was removed

ea98fb3

more gclient_gn_args

3b047f1

roll node to tmp version (branch more-patches)

f514445

stop using x-devtools-emulate-network-conditions-client-id header

3ded109

https://chromium-review.googlesource.com/c/chromium/src/+/1086949

Migrate MediaResponseCallback to OnceCallback

90aa277

https://chromium-review.googlesource.com/c/chromium/src/+/1093052

Replace DupCryptoBuffer with bssl::UpRef

4f540fe

https://chromium-review.googlesource.com/c/chromium/src/+/1128194

ChildProcessSecurityPolicy: only use granted schemes for requests

a7c687f

https://chromium-review.googlesource.com/c/chromium/src/+/1108485

Rename base::Timer to base::TimerBase

c576d44

https://chromium-review.googlesource.com/c/chromium/src/+/1124200

Change CreateWebUIControllerForURL() to return a unique_ptr

2a3a845

https://chromium-review.googlesource.com/c/chromium/src/+/1087627

Unify notification-related permission checks in its PermissionContext

d13e332

https://chromium-review.googlesource.com/c/chromium/src/+/1085568 https://chromium-review.googlesource.com/c/chromium/src/+/1085466

FIXME: Move persistent notification id from notification database to …

95cec24

…profile https://chromium-review.googlesource.com/c/chromium/src/+/1114840

FIXME: Delete RenderWidgetHostViewMac::AcceleratedWidgetGetNSView

ec1bd53

https://chromium-review.googlesource.com/c/chromium/src/+/1121957 https://chromium-review.googlesource.com/c/chromium/src/+/1037145

Use CompletionOnceCallback

18128a1

several CLs, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1092933

Support add/overwrite redirect request headers in NavigationURLLoader

9c2cd5a

https://chromium-review.googlesource.com/c/chromium/src/+/1072643

media: Refactor KeySystemSupport

7861f75

https://chromium-review.googlesource.com/c/chromium/src/+/1102836

Rename content::PermissionManager into content::PermissionControllerD…

af03e4a

…elegate https://chromium-review.googlesource.com/c/chromium/src/+/1136858

Rename WebContentsDelegate methods

4570330

https://chromium-review.googlesource.com/c/chromium/src/+/1085427

nornagon and others added 13 commits October 9, 2018 14:39

ci: enable stack dumping in tests

26a46b6

spec: update media-started-playing tests based on the autoplay policy

7ec05fb

FIXME: disable net log spec

ba14dbe

FIXME: disable document.visibilityState/hidden <webview> spec

3364c04

fixme: always run "nightly-release-test" workflow

a71c814

fixme: allow huge Electron archives

f7dee77

fix: compile error on mas

2815364

chore: update line reference in gpuinfo comment

ee8a54d

FIXME: disable getGPUInfo test to unblock merge

edb96c8

should be fixed and re-enabled before release

FIXME: disable isCurrentlyAudible test to unblock merge

c8a9a3f

FIXME: try enabling dcheck to see if that will get us more info on li…

1a17ce8

…nux-release-testing

docs: document BrowserWindow.setBackgroundColor

373ffa9

fix: [mac] restore SetBackgroundColor functionality

30850f4

nornagon force-pushed the chromium-upgrade/69 branch from c33c050 to 30850f4 Compare October 9, 2018 21:39

nornagon and others added 3 commits October 9, 2018 15:43

FIXME: temporary debugging to maybe diagnose netlog issue on mac

f8f318d

fix: use valid markdown syntax in browser-window.md to fix docs linter

6b621e2

chore: add logging to zip-symbols.py to help debugging timeouts

19e02cd

nornagon approved these changes Oct 10, 2018

View reviewed changes

MarshallOfSound added 2 commits October 10, 2018 12:11

chore: remove --enable-logging, causing issues on CI

a5c3091

fixme: dont use --enable-logging on the ffmpeg verify phase

2b8ef34

MarshallOfSound approved these changes Oct 10, 2018

View reviewed changes

MarshallOfSound and others added 2 commits October 10, 2018 14:02

fix: ensure that the window is focused when testing spellchecker

2420cdf

fix: simplify SetBackgroundColor

dd43e92

The compositor_superview member of BridgedNativeWidgetMac has been removed so as a consequence there is only one layer on which we need to call setBackgroundColor

MarshallOfSound merged commit cc0c6ad into master Oct 10, 2018

ckerr deleted the chromium-upgrade/69 branch October 11, 2018 15:50

ckerr mentioned this pull request Dec 18, 2018

Draft 4.0.0 Release Notes #16117

Closed

erickzhao mentioned this pull request Jun 17, 2019

Add BrowserWindow#setBackgroundColor() method #13464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to Chromium 69.0.3497.106 #14972

feat: upgrade to Chromium 69.0.3497.106 #14972

alexeykuzmin commented Oct 4, 2018

KoenLav commented Oct 4, 2018

nornagon commented Oct 4, 2018

alexeykuzmin Oct 8, 2018

brenca Oct 8, 2018

nornagon left a comment •

edited

MarshallOfSound left a comment

release-clerk bot commented Oct 10, 2018

KoenLav commented Oct 11, 2018

ckerr commented Oct 11, 2018

feat: upgrade to Chromium 69.0.3497.106 #14972

feat: upgrade to Chromium 69.0.3497.106 #14972

Conversation

alexeykuzmin commented Oct 4, 2018

Description of Change

Checklist

Release Notes

KoenLav commented Oct 4, 2018

nornagon commented Oct 4, 2018

alexeykuzmin Oct 8, 2018

Choose a reason for hiding this comment

brenca Oct 8, 2018

Choose a reason for hiding this comment

nornagon left a comment • edited

Choose a reason for hiding this comment

MarshallOfSound left a comment

Choose a reason for hiding this comment

release-clerk bot commented Oct 10, 2018

KoenLav commented Oct 11, 2018

ckerr commented Oct 11, 2018

nornagon left a comment •

edited