feat: add app.enableSandbox() #14999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
requested review from
nornagon,
tarruda,
codebytere,
nitsakh and
a team
miniak
force-pushed
the
miniak/app-enable-full-sandbox
branch
from
7002e51
to
05e7361
Compare
|
Another possible name is |
alexeykuzmin
reviewed
Oct 7, 2018
| const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app') | ||
| appProcess = ChildProcess.spawn(remote.process.execPath, [appPath, '--app-enable-sandbox']) | ||
|
|
||
| server.once('error', error => { done(error) }) |
There was a problem hiding this comment.
I want to use async/await, but does it look cleaner here?
// Throws on error.
const client = await Promise.race([
emittedOnce(server, 'connection').then(([, client]) => client),
emittedOnce(server, 'error').then(([, error]) => Promise.reject(error))
])
const data = await emittedOnce(client, 'data')
const argv = JSON.parse(data)
<...>
ckerr
approved these changes
Oct 9, 2018
There was a problem hiding this comment.
👍 on @alexeykuzmin's suggestion of using async/await in the spec but the rest of the PR looks solid
|
I can create a separate follow up PR to improve the tests using the await/async pattern. |
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
app.enableSandbox()to allow turning on full sandbox without having to run the app with--enable-sandboxswitch.Checklist
npm testpassesRelease Notes
Notes: Added
app.enableSandbox()API