fix: Menu accelerators not working #15094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Oct 11, 2018
|
LGTM once the CI passes :) |
codebytere
approved these changes
Oct 13, 2018
5 tasks
nitsakh
force-pushed
the
menu-fix
branch
2 times, most recently
from
0ad34e4
to
a7ef8a1
Compare
Try sending robot keys differently
5 tasks
|
@nitsakh what's the current status of this? |
|
@codebytere it'll be great if you can please take another look at this one. Should be ready to merge once approved again. |
codebytere
approved these changes
Nov 9, 2018
|
Release Notes Persisted
|
|
I was unable to backport this PR to "3-0-x" cleanly; |
|
I was unable to backport this PR to "4-0-x" cleanly; |
nitsakh
added a commit
that referenced
this pull request
Nov 9, 2018
This change fixes the regression in the menu accelerators working in linux, on some environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes #14252.
Menu Accelerators were not working on Linux with Unity, global menus.
Checklist
npm testpassesRelease Notes
Notes: Fixed bug that caused menu accelerators to stop working on some linux